Switch order of approval-single list queries #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #772 +/- ##
===============================================
+ Coverage 96.27% 96.32% +0.04%
===============================================
Files 203 203
Lines 50300 50186 -114
===============================================
- Hits 48428 48341 -87
+ Misses 1872 1845 -27 ☔ View full report in Codecov by Sentry. |
JakeHartnell
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ordering of approval-single List and ReverseList queries is incorrect and does not match the normal proposal modules. The forward list query has a
start_afterparameter but was sorted in descending order, which does not make sense. The opposite was true for the reverse list query.This PR makes the forward list query sort ascending, which makes sense for
start_after, and the reverse list query sort descending, which makes sense forstart_before.It also now matches the rest of the codebase.